fix: improve AssertIsCrumb readability and add constant check #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add constant value check at the start of AssertIsCrumb to avoid unnecessary constraint generation for compile-time constants. Use separate variable x instead of overwriting input parameter for better code clarity. Add mathematical comment explaining the polynomial constraint derivation, matching the SCS implementation style.
ivokub
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constant value check at the start of AssertIsCrumb to avoid unnecessary constraint generation for compile-time constants.
Use separate variable x instead of overwriting input parameter for better code clarity.
Add mathematical comment explaining the polynomial constraint derivation, matching the SCS implementation style.
Note
Add constant-input check and clearer/optimized constraints for
AssertIsCrumbin R1CS/SCS, plus new snippet and stats entries.AssertIsCrumb):frontend/cs/r1cs/api_assertions.go):xand enforcex(x+2)==0via twoMulAccthenAssertIsEqual.frontend/cs/scs/api_assertions.go):xand enforce2x + x^2 == 0via a single PLONK constraint; add explanatory comments.api/AssertIsCrumb(internal/stats/snippet.go).internal/stats/latest_stats.csvwithapi/AssertIsCrumbmetrics for multiple curves/backends (Groth16, PLONK).Written by Cursor Bugbot for commit 03dee3a. This will update automatically on new commits. Configure here.